Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow retry directive that declares no retry #2284

Closed
wesbillman opened this issue Aug 7, 2024 · 0 comments · Fixed by #2479
Closed

Allow retry directive that declares no retry #2284

wesbillman opened this issue Aug 7, 2024 · 0 comments · Fixed by #2479
Assignees
@matt2e

Comments

@wesbillman
Copy link
Collaborator

wesbillman commented Aug 7, 2024 •
edited by matt2e
Loading

Use cases:

  • We want to catch failures but we don't want retries
  • We want a default retry policy on an FSM but want to opt out of retries on a specific transition

Possibilities
ftl:retry 0 and ftl:retry 0 catch a.b

ftl:retry none and ftl:retry none catch a.b

ftl:retry disable and ftl:retry disable catch a.b

  • disable catch seems confusing

ftl:catch a.b

  • It's confusing that this overrides retry policy when it doesnt explictly mention retry
@github-actions github-actions bot added the triage Issue needs triaging label Aug 7, 2024
@ftl-robot ftl-robot mentioned this issue Aug 7, 2024
Open
@matt2e matt2e self-assigned this Aug 7, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Aug 7, 2024
@matt2e matt2e changed the title Add support for 0 retries Allow retry directive that declares no retry Aug 7, 2024
@matt2e matt2e mentioned this issue Aug 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 23, 2024
@matt2e
feat: allow retry 0 directives (#2479)
637f20a 
closes #2284
This allows for:
- fsm transitions to opt out of the default fsm retry policy
- having a catch verb without any retries

eg:
```
//ftl:retry 0
//ftl:retry 0 catch recover
//ftl:retry 0 1s catch recover
```

Not allowed because it doesn't make sense:
```
//ftl:retry 0 1s
```
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow retry 0 directives block/ftl
2 participants
@wesbillman @matt2e