Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in generated stubs for value enums where type is an alias #2254

Closed
worstell opened this issue Aug 5, 2024 · 0 comments · Fixed by #2300
Closed

bug in generated stubs for value enums where type is an alias #2254

worstell opened this issue Aug 5, 2024 · 0 comments · Fixed by #2300
Assignees
@worstell

Comments

@worstell
Copy link
Contributor

worstell commented Aug 5, 2024

e.g.

type PaymentState = string

type PayinState = PaymentState

const (
	PayinPending       PayinState = "PAYIN_PENDING"
	PayinInitiated     PayinState = "PAYIN_INITIATED"
	PayinSettled       PayinState = "PAYIN_SETTLED"
)

type PayoutState = PaymentState

const (
	PayoutWeCancelled   PayoutState = "PAYOUT_WE_CANCELLED"
	PayoutTheyCancelled PayoutState = "PAYOUT_THEY_CANCELLED"
)
@worstell worstell self-assigned this Aug 5, 2024
@ftl-robot ftl-robot mentioned this issue Aug 5, 2024
Open
@worstell worstell mentioned this issue Aug 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 8, 2024
@worstell
fix: value enum bugs (#2300)
1bb1268 
fixes value enum type validation
const block variants with the same underlying type are correctly
associated to their parent enum object

fixes #2254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: value enum bugs block/ftl
1 participant
@worstell