Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend builtin.HttpRequest to have separate type parameters for body, path parameters, headers, and query? #2230

Closed
alecthomas opened this issue Aug 1, 2024 · 0 comments · Fixed by #2422
Closed

Extend builtin.HttpRequest to have separate type parameters for body, path parameters, headers, and query? #2230

alecthomas opened this issue Aug 1, 2024 · 0 comments · Fixed by #2422
Assignees
@stuartwdouglas

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Aug 1, 2024 •
edited
Loading

This gives us strong typing, without having to merge values from different parts of the request payload into the "body" type as we are doing currently.

Old:

  export data HttpRequest<Body> {
    method String
    path String
    pathParameters {String: String}
    query {String: [String]}
    headers {String: [String]}
    body Body
  }

New:

data HttpRequest<In, Path, Query, Headers> {
    method String
    path String
    pathParameters Path
    query Query
    headers Headers
    body Body
}

Too many type parameters? 🤔
@github-actions github-actions bot added the triage Issue needs triaging label Aug 1, 2024
@ftl-robot ftl-robot mentioned this issue Aug 1, 2024
Open
@gak gak added next Work that will be be picked up next and removed triage Issue needs triaging labels Aug 1, 2024
@matt2e matt2e mentioned this issue Aug 7, 2024
Open
@stuartwdouglas stuartwdouglas self-assigned this Aug 17, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Aug 17, 2024
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
b97affd 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
f8010ed 
fixes: #2230
@stuartwdouglas stuartwdouglas mentioned this issue Aug 19, 2024
Merged
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
2cfd4bf 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
c6518c1 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
01576f2 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
b9976fd 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
20ba0ac 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
f5b38bb 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
c5c65fb 
fixes: #2230

tmp: JVM HTTP tests
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
1fbd7de 
fixes: #2230

tmp: JVM HTTP tests
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
668d0b0 
fixes: #2230
stuartwdouglas added a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping
d422542 
fixes: #2230
github-merge-queue bot pushed a commit that referenced this issue Aug 19, 2024
@stuartwdouglas
feat: HttpRequest path and query mapping (#2422)
826dd3f 
fixes: #2230
safeer pushed a commit that referenced this issue Aug 19, 2024
@stuartwdouglas @safeer
feat: HttpRequest path and query mapping (#2422)
0e5ef15 
fixes: #2230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: HttpRequest path and query mapping block/ftl
3 participants
@gak @alecthomas @stuartwdouglas