Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow type aliases for ingress req/response if their value is builtin.HttpRequest/Response #2145

Closed
worstell opened this issue Jul 24, 2024 · 0 comments · Fixed by #2154
Closed

allow type aliases for ingress req/response if their value is builtin.HttpRequest/Response #2145

worstell opened this issue Jul 24, 2024 · 0 comments · Fixed by #2154
Assignees
@worstell

Comments

@worstell
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the triage Issue needs triaging label Jul 24, 2024
@ftl-robot ftl-robot mentioned this issue Jul 24, 2024
Open
@worstell worstell self-assigned this Jul 24, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 24, 2024
worstell added a commit that referenced this issue Jul 24, 2024
@worstell
feat: extract type by node + add schema fuzz test (#2138)
46c7275 
this change also allows us to support `type Foo = external.Bar` aliases

fixes #2145
@worstell worstell mentioned this issue Jul 24, 2024
Merged
worstell added a commit that referenced this issue Jul 24, 2024
@worstell
feat: extract type by node + add schema fuzz test (#2138)
856fba3 
user requested support for `type Foo = other.Bar` pattern when declaring type aliases. this allows them to leverage member functions of the underlying type.

after this change, the above pattern as well as the prior pattern, `type Foo other.Bar` will be supported for type aliasing.

also fixes #2145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: extract type by node + add schema fuzz test (#2138) block/ftl
1 participant
@worstell