Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be strict with ingressed model objects, optionally #2132

Closed
safeer opened this issue Jul 22, 2024 · 0 comments · Fixed by #2377
Closed

Be strict with ingressed model objects, optionally #2132

safeer opened this issue Jul 22, 2024 · 0 comments · Fixed by #2377
Assignees
@worstell
Labels
P2

Comments

@safeer
Copy link
Contributor

safeer commented Jul 22, 2024

Relates to the fix for #2117 and #2119

We're currently lenient on inbound objects, which unblocks the client team, but they'd prefer to have it be optional. I.e. Jackson has: @JsonIgnoreProperties(ignoreUnknown = true)
@github-actions github-actions bot added the triage Issue needs triaging label Jul 22, 2024
@ftl-robot ftl-robot mentioned this issue Jul 22, 2024
Open
@bradleydwyer bradleydwyer added the next Work that will be be picked up next label Jul 22, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 22, 2024
@worstell worstell added the P2 label Jul 24, 2024
@worstell worstell self-assigned this Aug 5, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Aug 5, 2024
worstell added a commit that referenced this issue Aug 15, 2024
@worstell
feat: add directive to enable lenient json
93c6c6a 
fixes #2132
@worstell worstell mentioned this issue Aug 15, 2024
Merged
worstell added a commit that referenced this issue Aug 15, 2024
@worstell
feat: add directive to enable lenient json
7e1908b 
fixes #2132
worstell added a commit that referenced this issue Aug 15, 2024
@worstell
feat: add directive to enable lenient json
3aa40a4 
fixes #2132
worstell added a commit that referenced this issue Aug 15, 2024
@worstell
feat: add directive to enable lenient json
97afca9 
fixes #2132
worstell added a commit that referenced this issue Aug 15, 2024
@worstell
feat: add directive to enable lenient json
27c7c3b 
fixes #2132
github-merge-queue bot pushed a commit that referenced this issue Aug 15, 2024
@worstell @github-actions
feat: add directive to enable lenient json (#2377)
1d9a0e3 
fixes #2132

adds support for `ftl:encoding` directive. the default `ftl:encoding`
type is json and presently supports only the `lenient` option.

`//ftl:encoding lenient` or `//ftl:encoding json lenient` (which are
equivalent) can annotate an ingress verb. when an ingress verb is
annotated with this, it will accept requests with unknown/extra fields
and ignore them.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add directive to enable lenient json block/ftl
3 participants
@bradleydwyer @safeer @worstell