Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync asm secrets with db resolver references #2104

Closed
safeer opened this issue Jul 17, 2024 · 3 comments
Closed

Sync asm secrets with db resolver references #2104

safeer opened this issue Jul 17, 2024 · 3 comments

Comments

@safeer
Copy link
Contributor

safeer commented Jul 17, 2024

Currently, nuking / recreating the db removes all references to asm secrets, which means all secrets need to be set again. Client team has had to do this a few times.

Since we're tagging all asm secrets with "ftl", we can fetch them and add their refs to the db. Perhaps at first load / if we have zero refs?

@github-actions github-actions bot added the triage Issue needs triaging label Jul 17, 2024
@ftl-robot ftl-robot mentioned this issue Jul 17, 2024
@deniseli
Copy link
Contributor

That's a great idea

@safeer
Copy link
Contributor Author

safeer commented Jul 17, 2024

Alternative: introduce a command to attach an existing asm secret to a db ref, to allow client teams to bring in refs more intentionally. i.e. from @bradleydwyer:

ftl secret attach <ref> --asm --asm-ref=[asm id]

@jonathanj-square jonathanj-square removed the triage Issue needs triaging label Jul 18, 2024
@jonathanj-square
Copy link
Contributor

The team does not think there is work to be done here if we incrementally update the db instead of performing wipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants