Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain package structure in generated stubs #2053

Open
worstell opened this issue Jul 11, 2024 · 0 comments
Open

retain package structure in generated stubs #2053

worstell opened this issue Jul 11, 2024 · 0 comments

Comments

@worstell
Copy link
Contributor

we should consider retaining the package structure in generated stubs. because we flatten everything into a single module stub at the moment, we introduce a lot of unnecessary naming constraints that otherwise aren't required by the compiler (two types can't have the same name even across different packages, if they are in the same module).

proposal:
include namespace in the ref, e.g.
foo.Type
foo.subpackage.Type

and generate stubs with directory structure correspondingly

@github-actions github-actions bot added the triage Issue needs triaging label Jul 11, 2024
@ftl-robot ftl-robot mentioned this issue Jul 11, 2024
@wesbillman wesbillman removed the triage Issue needs triaging label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants