Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load passwords from 1Password quickly #1930

Closed
alecthomas opened this issue Jul 2, 2024 · 1 comment
Closed

Load passwords from 1Password quickly #1930

alecthomas opened this issue Jul 2, 2024 · 1 comment
Assignees
@matt2e
Labels
P0 Work on this now

Comments

@alecthomas
Copy link
Collaborator

Related to #1906

Turns out loading passwords from 1Password is really slow, so having a mutex around it makes deployments take 10-20 seconds each.

A couple of ideas for solutions:

  1. Change the 1Password provider to store all secrets in a JSON blob in a single password entry.
  2. Block on the first password fetch to avoid spamming the authentication prompt, then parallel load the remainder.
@alecthomas alecthomas added P0 Work on this now next Work that will be be picked up next labels Jul 2, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jul 2, 2024
@ftl-robot ftl-robot mentioned this issue Jul 2, 2024
Open
@matt2e matt2e self-assigned this Jul 2, 2024
@github-actions github-actions bot removed triage Issue needs triaging next Work that will be be picked up next labels Jul 2, 2024
@matt2e matt2e closed this as completed Jul 12, 2024
@matt2e
Copy link
Collaborator

matt2e commented Jul 12, 2024

Fixed in this epic #1951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
P0 Work on this now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @matt2e