Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename configuration.Resolver to configuration.Router #1886

Closed
alecthomas opened this issue Jun 26, 2024 · 0 comments
Closed

Rename configuration.Resolver to configuration.Router #1886

alecthomas opened this issue Jun 26, 2024 · 0 comments
Labels
good first issue Good for newcomers techdebt Issue is technical debt triage Issue needs triaging

Comments

@alecthomas
Copy link
Collaborator

"Resolver" is too ambiguous in this context, while "router" more accurately reflects its role.
@alecthomas alecthomas added good first issue Good for newcomers techdebt Issue is technical debt labels Jun 26, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 26, 2024
@ftl-robot ftl-robot mentioned this issue Jun 26, 2024
Open
@karimalzalek karimalzalek mentioned this issue Jun 27, 2024
Merged
alecthomas pushed a commit that referenced this issue Jun 27, 2024
@karimalzalek
chore: Change interface name from Resolver to Router in Configuration (…
e4bba48 
…#1895)

Hi ,
Would like some help with rebasing this PR.
This is for (Rename configuration.Resolver to configuration.Router)
#1886

Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers techdebt Issue is technical debt triage Issue needs triaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecthomas