Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-review for #1865 #1883

Closed
2 tasks done
alecthomas opened this issue Jun 26, 2024 · 1 comment
Closed
2 tasks done

Post-review for #1865 #1883

alecthomas opened this issue Jun 26, 2024 · 1 comment
Assignees
@jonathanj-square

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 26, 2024 •
edited by jonathanj-square
Loading

  • Switch to passing around the hash.Hash value from sha256.New() rather than custom 64-bit hashing
  • Stable sort the keys of the maps before hashing
@alecthomas alecthomas added the bug Something isn't working label Jun 26, 2024
@ftl-robot ftl-robot mentioned this issue Jun 26, 2024
Open
@alecthomas alecthomas removed the bug Something isn't working label Jun 26, 2024
@jonathanj-square
Copy link
Contributor

addressed by: #1911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanj-square jonathanj-square

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @jonathanj-square