Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error not showing up in VSCode #1849

Closed
alecthomas opened this issue Jun 21, 2024 · 1 comment · Fixed by #1929
Closed

Build error not showing up in VSCode #1849

alecthomas opened this issue Jun 21, 2024 · 1 comment · Fixed by #1929
Assignees
@gak
Labels
bug Something isn't working extension Issues related to our VSCode extension

Comments

@alecthomas
Copy link
Collaborator

In this example I am trying to call a function that is not exported as a verb, but I imagine this is a more general problem:

image
@alecthomas alecthomas added bug Something isn't working extension Issues related to our VSCode extension labels Jun 21, 2024
@ftl-robot ftl-robot mentioned this issue Jun 21, 2024
Open
@gak
Copy link
Contributor

gak commented Jul 2, 2024

Related #1893

@gak gak mentioned this issue Jul 2, 2024
Merged
gak added a commit that referenced this issue Jul 2, 2024
@gak
fix: diagnostic errors were being discarded (#1929)
423ae6a 
Fixes #1849 

Error detection was far too aggressive, discarding legit schema.Errors.
@gak gak closed this as completed in #1929 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gak gak

Labels
bug Something isn't working extension Issues related to our VSCode extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: diagnostic errors were being discarded block/ftl
2 participants
@gak @alecthomas