Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that user metrics are tagged sufficiently differently from FTL core metrics #1816

Closed
alecthomas opened this issue Jun 17, 2024 · 2 comments
Closed

Ensure that user metrics are tagged sufficiently differently from FTL core metrics #1816

alecthomas opened this issue Jun 17, 2024 · 2 comments
Assignees
@safeer
Labels
P2

Comments

@alecthomas
Copy link
Collaborator

They might need a different "app" or something? Not sure.
@github-actions github-actions bot added the triage Issue needs triaging label Jun 17, 2024
@ftl-robot ftl-robot mentioned this issue Jun 17, 2024
Open
@safeer safeer added next Work that will be be picked up next and removed triage Issue needs triaging labels Jun 17, 2024
@matt2e matt2e added the P2 label Jul 1, 2024
@bradleydwyer
Copy link
Collaborator

bradleydwyer commented Jul 9, 2024 •
edited
Loading

Use the project name from the toml to add a tag to logs and metrics sent to Datadog.

Also add a tag "app" to metrics/logs from application/deployed code in FTL - for non FTL events/logs.

@wesbillman
Copy link
Collaborator

Duplicate of #2023

@wesbillman wesbillman marked this as a duplicate of #2023 Jul 15, 2024
@safeer safeer self-assigned this Jul 30, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 30, 2024
@safeer safeer mentioned this issue Aug 5, 2024
Merged
safeer added a commit that referenced this issue Aug 5, 2024
@safeer
otel: add project_name and is_user_service attributes (#2255)
659b9e6 
Fixes #2023 #1816
@safeer safeer closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safeer safeer

Labels
P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alecthomas @wesbillman @bradleydwyer @safeer @matt2e