Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Should we rename json:"" tags to ftl-json:""? #1788

Open
alecthomas opened this issue Jun 14, 2024 · 0 comments
Open

RFC: Should we rename json:"" tags to ftl-json:""? #1788

alecthomas opened this issue Jun 14, 2024 · 0 comments
Labels
RFC Request for Comment

Comments

@alecthomas
Copy link
Collaborator

Now that we have diverged significantly from what encoding/json supports, it seems like it could be more confusing than helpful to support the json:"" tag.

A couple of examples of dissonance:

  • We use lowerCamelCase for untagged fields, whereas the stdlib uses the literal Go field name casing.
  • We support encoding/decoding sum types, Go does not at all.
@alecthomas alecthomas added the RFC Request for Comment label Jun 14, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 14, 2024
@ftl-robot ftl-robot mentioned this issue Jun 14, 2024
Open
@safeer safeer added next Work that will be be picked up next and removed triage Issue needs triaging next Work that will be be picked up next labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Request for Comment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @safeer