Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pubsub reliance on min_replicas #1660

Closed
Tracked by #1597
matt2e opened this issue Jun 5, 2024 · 0 comments · Fixed by #1752
Closed
Tracked by #1597

Remove pubsub reliance on min_replicas #1660

matt2e opened this issue Jun 5, 2024 · 0 comments · Fixed by #1752
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jun 5, 2024

See comments here: #1641 (comment)
@github-actions github-actions bot added the triage Issue needs triaging label Jun 5, 2024
This was referenced Jun 5, 2024
Closed
Merged
@ftl-robot ftl-robot mentioned this issue Jun 5, 2024
Open
@worstell worstell removed the triage Issue needs triaging label Jun 5, 2024
@matt2e matt2e mentioned this issue Jun 12, 2024
Merged
@matt2e matt2e self-assigned this Jun 16, 2024
matt2e added a commit that referenced this issue Jun 18, 2024
@matt2e
fix: remove old subscriptions and subscribers (#1752)
22f94f7 
fixes #1660
fixes #1685

changes:
- add hooks for when we activate and deactivate deployments
(`min_replicas > 0` vs `min_replicas == 0`)
- when activating a deployment:
    - upsert subscriptions (maintain state), insert subscribers
    - skip subscriptions with no subscribers (ie: do not insert into db)
- when deactivating a deployment:
    - delete subscriptions still owned by deployment
    - delete subscribers

Skipping subscriptions without subscribers fixes the case where pubsub
manager would get stuck trying to progress subscriptions without
subscribers, blocking real subscriptions from progressing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove old subscriptions and subscribers block/ftl
2 participants
@matt2e @worstell