Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move buildengine tests to integration tests #1585

Closed
alecthomas opened this issue May 28, 2024 · 0 comments · Fixed by #2511
Closed

Move buildengine tests to integration tests #1585

alecthomas opened this issue May 28, 2024 · 0 comments · Fixed by #2511
Assignees
@jvmakine
Labels
good first issue Good for newcomers techdebt Issue is technical debt

Comments

@alecthomas
Copy link
Collaborator

There's a lot of overlap in the test infrastructure and the buildengine tests are all quite slow.
@alecthomas alecthomas added the good first issue Good for newcomers label May 28, 2024
@github-actions github-actions bot added the triage Issue needs triaging label May 28, 2024
@alecthomas alecthomas added techdebt Issue is technical debt and removed triage Issue needs triaging labels May 28, 2024
@alecthomas alecthomas changed the title Move buildengine tests to to integration tests Move buildengine tests to integration tests May 28, 2024
@matt2e matt2e added the next Work that will be be picked up next label Jun 18, 2024
@ftl-robot ftl-robot mentioned this issue Jun 18, 2024
Open
@matt2e matt2e removed the next Work that will be be picked up next label Jul 1, 2024
@jvmakine jvmakine self-assigned this Aug 26, 2024
@jvmakine jvmakine mentioned this issue Aug 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@jvmakine
chore: migrate deploy_test to integration tests in buildengine (#2505)
c73de32 
This tests the same things as the old test, but through slightly higher
abstraction layer (cli instead of calling build engine functions
directly)

The same functions as in the original test should get called via the cli
in the integration test.

See #1585
@jvmakine jvmakine mentioned this issue Aug 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@jvmakine
test(buildengine): Convert buildengine tests into integration test (#…
eb88bc3 
…2508)

See #1585

I left engine_test in place, as there was one test for graph
construction that could not be done nicely as an integration test.
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@jvmakine
test(buildengine): Convert buildengine tests into integration test (#…
b29aca4 
…2508)

See #1585

I left engine_test in place, as there was one test for graph
construction that could not be done nicely as an integration test.
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@jvmakine
test(buildengine): Convert buildengine tests into integration test (#…
192d8e2 
…2508)

See #1585

I left engine_test in place, as there was one test for graph
construction that could not be done nicely as an integration test.
@jvmakine jvmakine mentioned this issue Aug 27, 2024
Merged
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@jvmakine
chore: convert watch_test into an integration test (#2511)
b5c95b3 
Not sure if this makes the watch tests much more readable, but at least
they are more consistent with the rest of the integration tests.

Closes #1585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvmakine jvmakine

Labels
good first issue Good for newcomers techdebt Issue is technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: convert watch_test into an integration test block/ftl
3 participants
@alecthomas @jvmakine @matt2e