Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should ftl secret set create a project toml if one is specified that doesn't exist? #1561

Closed
mistermoe opened this issue May 23, 2024 · 3 comments · Fixed by #1618
Closed

should ftl secret set create a project toml if one is specified that doesn't exist? #1561

mistermoe opened this issue May 23, 2024 · 3 comments · Fixed by #1618
Assignees
@deniseli

Comments

@mistermoe
Copy link
Collaborator

Slightly similar to #1338 but different in the sense that i'm specifying a toml file that isn't the default project toml e.g.

❯ echo -n "hi" | ftl secret set -C ftl-project-idk.toml --inline yo
ftl: error: open ftl-project-idk.toml: no such file or directory

instinctively i feel like the command should create the toml if it doesn't already exist but will leave that up to y'all to decide! maybe there's a good reason not to do this or there's another pre-existing command that should be used to create toml config files.
@github-actions github-actions bot added the triage Issue needs triaging label May 23, 2024
@ftl-robot ftl-robot mentioned this issue May 23, 2024
Open
@mistermoe
Copy link
Collaborator Author

lol whoa @ftl-robot can see into the future

image

@alecthomas Slack
Copy link
Collaborator

Agreed Moe

@alecthomas
Copy link
Collaborator

lol whoa @ftl-robot can see into the future

Makes you wonder about the fidelity of GitHub hey?

@gak gak added next Work that will be be picked up next and removed triage Issue needs triaging labels May 23, 2024
@deniseli deniseli self-assigned this May 31, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label May 31, 2024
This was referenced May 31, 2024
Merged
Closed
deniseli added a commit that referenced this issue Jun 4, 2024
@deniseli
feat: create specified config files that do not exist (#1618)
d4c9753 
Fixes: #1561

```
$ rm ftl-project-idk.toml
$ ftl config set yo --inline value -C ftl-project-idk.toml
warn: Creating a new project config file at "ftl-project-idk.toml" because the file does not already exist
$ ftl config set yo --inline value -C ftl-project-idk.toml
$ stat ftl-project-idk.toml                         
16777232 3291117 -rw------- 1 dli staff 0 125 "Jun  3 22:44:16 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" 4096 8 0 ftl-project-idk.toml
$
```
jonathanj-square pushed a commit that referenced this issue Jun 4, 2024
@deniseli @jonathanj-square
feat: create specified config files that do not exist (#1618)
448edf7 
Fixes: #1561

```
$ rm ftl-project-idk.toml
$ ftl config set yo --inline value -C ftl-project-idk.toml
warn: Creating a new project config file at "ftl-project-idk.toml" because the file does not already exist
$ ftl config set yo --inline value -C ftl-project-idk.toml
$ stat ftl-project-idk.toml                         
16777232 3291117 -rw------- 1 dli staff 0 125 "Jun  3 22:44:16 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" "Jun  3 22:44:15 2024" 4096 8 0 ftl-project-idk.toml
$
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create specified config files that do not exist block/ftl
4 participants
@gak @alecthomas @deniseli @mistermoe