Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collect runner DeploymentDir #1463

Closed
alecthomas opened this issue May 10, 2024 · 0 comments
Closed

Garbage collect runner DeploymentDir #1463

alecthomas opened this issue May 10, 2024 · 0 comments
Assignees
@gak
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented May 10, 2024 •
edited
Loading

We should periodically purge unused deployments from the runner DeploymentDir. Probably something like keeping the latest N deployments and nuking the rest one at a time, every M seconds. This must be an atomic operation, renaming the directory before commencing the delete.
@alecthomas alecthomas added the good first issue Good for newcomers label May 10, 2024
@github-actions github-actions bot added the triage Issue needs triaging label May 10, 2024
@alecthomas alecthomas mentioned this issue May 10, 2024
Open
@wesbillman wesbillman removed the triage Issue needs triaging label May 10, 2024
@alecthomas alecthomas mentioned this issue May 11, 2024
Closed
@gak gak self-assigned this May 14, 2024
gak added a commit that referenced this issue May 14, 2024
@gak
feat: remove old deployment dirs (#1463)
a9505b1
gak added a commit that referenced this issue May 14, 2024
@gak
feat: remove old deployment dirs (#1463) (#1474)
1e079ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gak gak

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gak @alecthomas @wesbillman