Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHashRing being flaky #1446

Closed
matt2e opened this issue May 9, 2024 · 1 comment · Fixed by #1467
Closed

TestHashRing being flaky #1446

matt2e opened this issue May 9, 2024 · 1 comment · Fixed by #1467
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented May 9, 2024 

=== Failed
=== FAIL: backend/controller/cronjobs TestHashRing (2.39s)
    /home/runner/work/ftl/ftl/backend/controller/cronjobs/cronjobs_test.go:109: expected verb crn-initial-verb37-2mzzde1fbjp5wfpt to be attempted by 2 controllers
        -1
        +2
@github-actions github-actions bot added the triage Issue needs triaging label May 9, 2024
@alecthomas alecthomas mentioned this issue May 9, 2024
Open
@matt2e matt2e self-assigned this May 9, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label May 9, 2024
@matt2e matt2e mentioned this issue May 12, 2024
Merged
matt2e added a commit that referenced this issue May 13, 2024
@matt2e
test: make TestHashRing() more reliable (#1467)
8b424bd 
This might make the test more reliable. fixes
#1446
We may have been hitting a deadlock situation where cronjobs were
setting up their observation of channels and calling `clock.Now()` while
the test tried to increment the mock clock (exact case is detailed more
in #1368).
@matt2e
Copy link
Collaborator Author

matt2e commented May 13, 2024

Closing as the latest change seems to have made it more reliable... but we should open this again if it continues to be flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: make TestHashRing() more reliable block/ftl
1 participant
@matt2e