Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recover() for tracing source of a panic #1443

Open
deniseli opened this issue May 8, 2024 · 0 comments
Open

Support recover() for tracing source of a panic #1443

deniseli opened this issue May 8, 2024 · 0 comments
Labels
intermediate A task requiring an intermediate level of knowledge

Comments

@deniseli
Copy link
Contributor

deniseli commented May 8, 2024

We recently encountered a panic in go-runtime/compile/schema.go (fix) triggered by the PFI code, but we were not able to easily identify exactly what line in PFI caused the panic. Alec suggested "we should have a recover() in the code that tracks the current node being parsed so we can report where the panic occurs. Something like defer catch(node)"

@github-actions github-actions bot added the triage Issue needs triaging label May 8, 2024
@alecthomas alecthomas mentioned this issue May 8, 2024
@matt2e matt2e added good first issue Good for newcomers and removed triage Issue needs triaging labels May 8, 2024
@alecthomas alecthomas added intermediate A task requiring an intermediate level of knowledge and removed good first issue Good for newcomers labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermediate A task requiring an intermediate level of knowledge
Projects
None yet
Development

No branches or pull requests

3 participants