ModuleContext should be immutable to avoid threading issues #1398
Assignees
Comments
Open
matt2e
added a commit
that referenced
this issue
May 3, 2024
fixes: #1398 Now a ModuleContext is built using the following functions: - `New(moduleName)` - `func (m ModuleContext) Update(configs map[string][]byte, secrets map[string][]byte, databases map[string]Database) ModuleContext` - `func (m ModuleContext) UpdateForTesting(mockVerbs map[schema.RefKey]MockVerb, allowDirectVerbBehavior bool) ModuleContext` - `func (m ModuleContext) UpdateFromEnvironment(ctx context.Context) (ModuleContext, error)` - (this one will still be split up and changed in an upcoming PR) `ftltest` now uses `ftltest.Options` as an opaque way of building up state to then create a ModuleContext with the above functions. Before we were passing around `context.Context` and mutating the ModuleContext directly each anything was changed. And now everything uses the ModuleContext struct directly, rather than with a pointer. This change won't have any effect on how users write their module unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: