Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad-hoc envar "protocol" with something more structured #1240

Closed
alecthomas opened this issue Apr 12, 2024 · 6 comments · Fixed by #1311
Closed

Replace ad-hoc envar "protocol" with something more structured #1240

alecthomas opened this issue Apr 12, 2024 · 6 comments · Fixed by #1311
Assignees

Comments

@alecthomas
Copy link
Collaborator

Currently we utilise a random set of environment variables such as FTL_CONFIG, FTL_ENDPOINT, LOG_LEVEL, etc. to propagate configuration state between the runner and the module it is executing. We should come up with something less gross.

One option would be to double down on using envars for this, but have a data structure that encapsulates it all. Another option would be to push some of this back to the Runner over gRPC. That is to read a config key or secret key, the user code calls a gRPC method on the Runner.

@github-actions github-actions bot added the triage Issue needs triaging label Apr 12, 2024
@deniseli deniseli removed the triage Issue needs triaging label Apr 12, 2024
@alecthomas alecthomas added triage Issue needs triaging next Work that will be be picked up next labels Apr 13, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 13, 2024
@alecthomas
Copy link
Collaborator Author

Just adding triage back to this one because someone needs to take this, so we should discuss next week.

@alecthomas alecthomas added triage Issue needs triaging and removed next Work that will be be picked up next labels Apr 13, 2024
@alecthomas
Copy link
Collaborator Author

Stupid bot.

@matt2e
Copy link
Collaborator

matt2e commented Apr 15, 2024

  • design doc
  • have a single get into ftl from user code that returns structured data for all of this

@github-actions github-actions bot removed the triage Issue needs triaging label Apr 15, 2024
@matt2e
Copy link
Collaborator

matt2e commented Apr 17, 2024

@wesbillman
Copy link
Collaborator

@matt2e is this issue related to this work here? Or something else #919

@alecthomas
Copy link
Collaborator Author

That one is more related to pulling config/secrets from different sources in production - ie. a DB table for config, and AWS Secrets Manager for secrets. The plumbing is there in the config resolvers, we just need implementations for them.

@matt2e matt2e linked a pull request Apr 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants