Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The FTL runtime should verify that the version of Go being executed is recent enough for the go.mod files #1184

Closed
alecthomas opened this issue Apr 5, 2024 · 0 comments
Closed

The FTL runtime should verify that the version of Go being executed is recent enough for the go.mod files #1184

alecthomas opened this issue Apr 5, 2024 · 0 comments
Assignees
@deniseli
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

If not, it should produce a useful error - currently it falls through to the Go toolchain and/or fails in weird ways.
@github-actions github-actions bot added the triage Issue needs triaging label Apr 5, 2024
@alecthomas alecthomas mentioned this issue Apr 5, 2024
Open
@alecthomas alecthomas added good first issue Good for newcomers next Work that will be be picked up next and removed next Work that will be be picked up next labels Apr 9, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 9, 2024
@alecthomas alecthomas added the next Work that will be be picked up next label Apr 9, 2024
@deniseli deniseli self-assigned this Apr 17, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Apr 17, 2024
@deniseli deniseli mentioned this issue Apr 17, 2024
Merged
deniseli added a commit that referenced this issue Apr 17, 2024
@deniseli
feat: Fail the go build early if go version is not compatible with go…
398a85d 
….mod file (#1292)

Fixes issue #1184

Note: `TestGenerateAllTypes` in `build_kotlin_test.go` is failing on
`main`. This PR touches the code for that but doesn't change any of the
behavior or assertions so it will continue to fail.

Tested manually as well:
```
$ ftl build highgoversion
info:highgoversion: Building module
ftl: error: go version "1.22.2" is not recent enough for this module, needs minimum version "9000.1.1"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @deniseli