Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum required FTL version to ftl-project.toml and/or ftl.toml #1183

Closed
alecthomas opened this issue Apr 5, 2024 · 1 comment
Closed

Add minimum required FTL version to ftl-project.toml and/or ftl.toml #1183

alecthomas opened this issue Apr 5, 2024 · 1 comment
Assignees
@deniseli
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

The ftl binary would validate this against its own version.
@alecthomas alecthomas added the good first issue Good for newcomers label Apr 5, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Apr 5, 2024
@alecthomas alecthomas mentioned this issue Apr 5, 2024
Open
@worstell worstell self-assigned this Apr 8, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 8, 2024
@worstell worstell assigned deniseli and unassigned worstell Apr 8, 2024
This was referenced Apr 10, 2024
Closed
Merged
deniseli added a commit that referenced this issue Apr 15, 2024
@deniseli
feat: Add ftl-min-version to ftl-project.toml (#1244)
24b81a6 
Issue #1183

Logic for what versions pass/fail is documented in `version.go`.

Manually tested the changes to `cmd/ftl/main.go` by:
 * Set ftl.Version by hardcoding it in ftl/Justfile
 * Set ftl-min-version in the top level ftl/ftl-project.toml
 * `just build ftl` to make an FTL binary
 * `build/release/ftl schema get` to see if it fatals or not
* Successfully got: `ftl: error: FTL version '0.1.1' predates the
minimum version '10.0.1'`
* When it worked correctly, with no error: `ftl: error: unavailable:
dial tcp [::1]:8892: connect: connection refused`
@deniseli
Copy link
Contributor

Going ahead and closing this since the ftl-project.toml change is in, we decided to defer any further design work, and any planning on how we'd support this in ftl.toml require a bit of design/thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alecthomas @deniseli @worstell