Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify error reporting functions #1128

Closed
alecthomas opened this issue Mar 22, 2024 · 2 comments
Closed

Unify error reporting functions #1128

alecthomas opened this issue Mar 22, 2024 · 2 comments
Labels
triage Issue needs triaging

Comments

@alecthomas
Copy link
Collaborator

I'm still seeing errors like this:

ftl: error: failed to build "module echo": failed to extract module schema: /Users/alec/dev/ftl/integration/testdata/go/httpingress/echo.go:160:1: ingress verb arrayData: request type builtin.HttpRequest<[ArrayType]>: 4:3: failed to monomorphise: /Users/alec/dev/ftl/integration/testdata/go/httpingress/echo.go:160:1: array element: /Users/alec/dev/ftl/integration/testdata/go/httpingress/echo.go:160:1: unknown type parameter "ArrayType"

I think the solution to this is to create a unified error type containing positional information, along with Errorf and Wrapf functions, that preserve a single error position. Basically identical to what is in the go-runtime, but shared, probably in backend/schema.

@github-actions github-actions bot added the triage Issue needs triaging label Mar 22, 2024
@wesbillman
Copy link
Collaborator

@alecthomas
Copy link
Collaborator Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants