Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller and runner ids #1047

Closed
matt2e opened this issue Mar 8, 2024 · 0 comments · Fixed by #1071
Closed

Update controller and runner ids #1047

matt2e opened this issue Mar 8, 2024 · 0 comments · Fixed by #1071
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Mar 8, 2024

In production, use the format runner-<hostname>-<random> , controller-<hostname>-<random>
Locally use some kind of incrementing id for ease of development
@matt2e matt2e self-assigned this Mar 8, 2024
@alecthomas alecthomas mentioned this issue Mar 8, 2024
Open
@matt2e matt2e mentioned this issue Mar 12, 2024
Merged
matt2e added a commit that referenced this issue Mar 13, 2024
@matt2e @github-actions
feat: keys include host-port-suffix (#1071)
e564ab1 
Fixes #1047
Fixes #1045

Changes `ControllerKey` and `RunnerKey` to have the format:
- `<r/c>-<hostname>-<port>-<4bytehex>` for passing around
- `<hostname>-<port>-<4bytehex>` in the db
- non production environments use shorter keys:
`r-<incrementing-digits>` and `<incrementing digits>` in db

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: keys include host-port-suffix block/ftl
1 participant
@matt2e