From f2597eb273884338cbda5dabfb9986a049ea95d8 Mon Sep 17 00:00:00 2001 From: Wes Date: Thu, 30 May 2024 15:28:50 -0700 Subject: [PATCH] fix: flaky type registry test (#1605) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #1580 It seemed like the test was just wrong, so I updated it. I ran it a bunch locally and it seemed ok 🤷 --- buildengine/build_go_test.go | 1 - buildengine/testdata/type_registry_main.go | 9 --------- 2 files changed, 10 deletions(-) diff --git a/buildengine/build_go_test.go b/buildengine/build_go_test.go index 4d5ef5b112..3beab1cfdc 100644 --- a/buildengine/build_go_test.go +++ b/buildengine/build_go_test.go @@ -300,7 +300,6 @@ func TestGoModVersion(t *testing.T) { } func TestGeneratedTypeRegistry(t *testing.T) { - t.Skip("FLAKY") if testing.Short() { t.Skipf("skipping test in non-short mode") } diff --git a/buildengine/testdata/type_registry_main.go b/buildengine/testdata/type_registry_main.go index d1e94075ca..28722bfd7f 100644 --- a/buildengine/testdata/type_registry_main.go +++ b/buildengine/testdata/type_registry_main.go @@ -9,20 +9,11 @@ import ( "github.com/TBD54566975/ftl/go-runtime/ftl/reflection" "github.com/TBD54566975/ftl/go-runtime/server" - "ftl/another" "ftl/other" ) func init() { reflection.Register( - reflection.SumType[another.SecondTypeEnum]( - *new(another.One), - *new(another.Two), - ), - reflection.SumType[another.TypeEnum]( - *new(another.A), - *new(another.B), - ), reflection.SumType[other.SecondTypeEnum]( *new(other.A), *new(other.B),