From 43cd92e1790f29716013a4172c0234f774ba3b4f Mon Sep 17 00:00:00 2001
From: Stuart Douglas <stuart.w.douglas@gmail.com>
Date: Tue, 1 Oct 2024 12:32:46 +1000
Subject: [PATCH] fix: prevent possible busy loop

Failure to remove old deployments should not be a fatal error.

fixes: #2885
---
 backend/runner/runner.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/backend/runner/runner.go b/backend/runner/runner.go
index 335f9c3753..7f46699dae 100644
--- a/backend/runner/runner.go
+++ b/backend/runner/runner.go
@@ -174,7 +174,8 @@ func manageDeploymentDirectory(logger *log.Logger, config Config) error {
 
 			err := os.RemoveAll(old)
 			if err != nil {
-				return fmt.Errorf("failed to remove old deployment: %w", err)
+				// This is not a fatal error, just log it.
+				logger.Errorf(err, "Failed to remove old deployment: %s", deployment.Name())
 			}
 		}
 	}