From 2c66fd0b7cf09750439e97d6939898e133f44642 Mon Sep 17 00:00:00 2001 From: Stuart Douglas Date: Fri, 4 Oct 2024 10:59:19 +1000 Subject: [PATCH] fix: duplicate log lines (#2990) fixes: #2962 --- backend/runner/runner.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/backend/runner/runner.go b/backend/runner/runner.go index 8f4517acdc..0ab02ce5bf 100644 --- a/backend/runner/runner.go +++ b/backend/runner/runner.go @@ -472,7 +472,6 @@ func (s *Service) registrationLoop(ctx context.Context, send func(request *ftlv1 func (s *Service) streamLogsLoop(ctx context.Context, send func(request *ftlv1.StreamDeploymentLogsRequest) error) error { delay := time.Millisecond * 500 - logger := log.FromContext(ctx) select { case entry := <-s.deploymentLogQueue: @@ -490,9 +489,6 @@ func (s *Service) streamLogsLoop(ctx context.Context, send func(request *ftlv1.S if reqStr, ok := entry.Attributes["request"]; ok { request = &reqStr } - // We also just output the log normally, so it shows up in the pod logs and gets synced to DD etc. - // It's not clear if we should output this here on or on the controller side. - logger.Log(entry) err := send(&ftlv1.StreamDeploymentLogsRequest{ RequestKey: request,