From 1c296f54223ff62eb6f7f0b54ae3341740638f86 Mon Sep 17 00:00:00 2001 From: Matt Toohey Date: Mon, 8 Jul 2024 13:02:02 +1000 Subject: [PATCH] fix: do not verify obfuscated contents of 1password (#1999) We now obfuscate secrets which caused errors when retrieving values from 1Password because the provider was making sure the value was json --- common/configuration/1password_provider.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/common/configuration/1password_provider.go b/common/configuration/1password_provider.go index 09226ad574..06d65c800f 100644 --- a/common/configuration/1password_provider.go +++ b/common/configuration/1password_provider.go @@ -45,13 +45,6 @@ func (o OnePasswordProvider) Load(ctx context.Context, ref Ref, key *url.URL) ([ return nil, fmt.Errorf("password field not found in item %q", ref) } - // Just to verify that it is JSON encoded. - var decoded interface{} - err = json.Unmarshal(secret, &decoded) - if err != nil { - return nil, fmt.Errorf("secret is not JSON encoded: %w", err) - } - return secret, nil }