From 01344b6b88e089322e68afc123083cec9536e42b Mon Sep 17 00:00:00 2001 From: Jon Johnson <113393155+jonathanj-square@users.noreply.github.com> Date: Tue, 1 Oct 2024 21:44:37 -0700 Subject: [PATCH] applying PR feedback --- backend/controller/artefacts/dal_registry.go | 2 +- backend/controller/controller.go | 2 +- backend/controller/dal/dal.go | 4 ++-- backend/controller/timeline/timeline_test.go | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/controller/artefacts/dal_registry.go b/backend/controller/artefacts/dal_registry.go index 2c3bbcd1f0..42e7e9728e 100644 --- a/backend/controller/artefacts/dal_registry.go +++ b/backend/controller/artefacts/dal_registry.go @@ -30,7 +30,7 @@ type Service struct { db sql.Querier } -func New(_ context.Context, conn libdal.Connection) *Service { +func New(conn libdal.Connection) *Service { return &Service{ db: sql.New(conn), Handle: libdal.New(conn, func(h *libdal.Handle[Service]) *Service { diff --git a/backend/controller/controller.go b/backend/controller/controller.go index 0cf9922e58..75dae70dca 100644 --- a/backend/controller/controller.go +++ b/backend/controller/controller.go @@ -277,7 +277,7 @@ func New(ctx context.Context, conn *sql.DB, config Config, devel bool, runnerSca pubSub := pubsub.New(conn, encryption, svc.tasks, optional.Some[pubsub.AsyncCallListener](svc)) svc.pubSub = pubSub - svc.registry = artefacts.New(ctx, conn) + svc.registry = artefacts.New(conn) svc.dal = dal.New(ctx, conn, encryption, pubSub) diff --git a/backend/controller/dal/dal.go b/backend/controller/dal/dal.go index 6c488639dd..cf2a43a40f 100644 --- a/backend/controller/dal/dal.go +++ b/backend/controller/dal/dal.go @@ -58,7 +58,7 @@ func New(ctx context.Context, conn libdal.Connection, encryption *encryption.Ser leaser: dbleaser.NewDatabaseLeaser(conn), db: db, encryption: encryption, - registry: aregistry.New(ctx, conn), + registry: aregistry.New(conn), Handle: libdal.New(conn, func(h *libdal.Handle[DAL]) *DAL { return &DAL{ Handle: h, @@ -66,7 +66,7 @@ func New(ctx context.Context, conn libdal.Connection, encryption *encryption.Ser leaser: dbleaser.NewDatabaseLeaser(h.Connection), pubsub: pubsub, encryption: d.encryption, - registry: aregistry.New(ctx, h.Connection), + registry: aregistry.New(h.Connection), DeploymentChanges: d.DeploymentChanges, } }), diff --git a/backend/controller/timeline/timeline_test.go b/backend/controller/timeline/timeline_test.go index ff749828b8..c61843d0f9 100644 --- a/backend/controller/timeline/timeline_test.go +++ b/backend/controller/timeline/timeline_test.go @@ -35,7 +35,7 @@ func TestTimeline(t *testing.T) { assert.NoError(t, err) timeline := New(ctx, conn, encryption) - registry := artefacts.New(ctx, conn) + registry := artefacts.New(conn) scheduler := scheduledtask.New(ctx, model.ControllerKey{}, leases.NewFakeLeaser()) pubSub := pubsub.New(conn, encryption, scheduler, optional.None[pubsub.AsyncCallListener]()) controllerDAL := controllerdal.New(ctx, conn, encryption, pubSub) @@ -223,7 +223,7 @@ func TestDeleteOldEvents(t *testing.T) { assert.NoError(t, err) timeline := New(ctx, conn, encryption) - registry := artefacts.New(ctx, conn) + registry := artefacts.New(conn) scheduler := scheduledtask.New(ctx, model.ControllerKey{}, leases.NewFakeLeaser()) pubSub := pubsub.New(conn, encryption, scheduler, optional.None[pubsub.AsyncCallListener]()) controllerDAL := controllerdal.New(ctx, conn, encryption, pubSub)