Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't switch the expanded list of solutions option off #207

Open
TNG02 opened this issue Jun 12, 2024 · 10 comments
Open

Can't switch the expanded list of solutions option off #207

TNG02 opened this issue Jun 12, 2024 · 10 comments
Assignees

Comments

@TNG02
Copy link

TNG02 commented Jun 12, 2024

A while back on my Welsh course, I clicked the button that has the fly-over hint "View the expanded list of solutions, including all automatically generated variants. More exhaustive but more readable." and I am getting lots of presumably generated garbage that includes lots of spelling that are not 'valid' Welsh.

The other option can't now be switched on and the fly over help says "[Unavailable] View the list of solutions as written by the course contributors. Less exhaustive, but more readable."

Is the currently unavailable option just no longer possible or is there something I can do to remove the unwanted versions?

Many thanks for the plugin which is brilliant!

@blmage blmage self-assigned this Jun 19, 2024
@blmage
Copy link
Owner

blmage commented Jun 19, 2024

Thank you for your kind words about the plugin!

After observing the situation for some time, it seems that the compactTranslations sent along with the session data are now always empty, which means that we don't have a source of "canonical" solutions anymore. I'll remove the buttons in the next release.

Regarding the Welsh course, do you think there is anything we can do to clean up the lists of solutions that are clearly incorrect?
We already have a number of heuristics to detect incorrect words, so any method based on inspecting the words could help. Please let me know if you have any specific suggestions or patterns you've noticed!

@TNG02
Copy link
Author

TNG02 commented Jun 19, 2024 via email

@blmage
Copy link
Owner

blmage commented Jun 21, 2024

Sorry to hear about your health issues, and thanks for offering to help nonetheless!

From your example, it seems we can identify a pattern where every occurrence of di is replaced by dy and ti to generate (incorrect) variants. After some research, it appears safe to ignore these variants, so I'll make sure to implement this in the next release.

For the rest, examples like the one you provided should help us identify more patterns, so please feel free to share any others you come across!

@TNG02
Copy link
Author

TNG02 commented Jun 21, 2024 via email

@blmage
Copy link
Owner

blmage commented Jun 25, 2024

Version 4.18.3 is now available, let me know what you think!

Regarding your question:

To take:
Would Megan [care / mind]?
and return
Would Megan care?
Would Megan mind?

Do you happen to know of a utility that does this?

None that I can think of, but knowing that this feature is more or less already built into the extension, it can probably be extracted in a quick-and-dirty form.

On the same principle, I'll also consider adding an "export" option for solution lists. It should not be too complicated to implement, and may prove useful for some users.

@TNG02
Copy link
Author

TNG02 commented Jun 25, 2024 via email

@blmage
Copy link
Owner

blmage commented Jun 27, 2024

You've given absolute top quality support and afaict you don't even offer an option for users to donate. Do you have an Amazon wish list?

I used to have a donation button on one of my older projects, but ended up feeling better without it. The simple fact that the extension can help people is rewarding enough, but I do really appreciate your support!

In the first section the word godi is correct and the words gody and goti are incorrect.
The second section fits the pattern you identified where dy is replaced with di and dt.

Somehow the cleanup code was fine until I decided that it should apply to sorted tokens instead, because it seems that the correct words always come first in the lists. This will be fixed in the upcoming release, thanks for bringing this to my attention!

I could send you the spreadhseet (Excel?) with the examples I've come across but presume that this isn't going to be particularly useful to you?

If you can find some way to highlight where the error is in each sentence, then anything will do.

Were you saying that code to do this is within your plugin code and it would therefore just be matter of hacking it around a bit?

Yes, the export feature is ready and will be available in the next version - I'm going to extract it to a web page where one can enter a custom list of solutions soon, probably on a GitHub page. I'll let you know when it's up!

@TNG02
Copy link
Author

TNG02 commented Jul 2, 2024 via email

@blmage
Copy link
Owner

blmage commented Jul 11, 2024

Sorry for the delay, I was convinced that I had posted an answer, but it turns out that I somehow did not.

I really understand that but perhaps you have a pet cause that I could donate to, otherwise I'll pay it forward to the next person that I find in need.

Thank you for your generosity! I don't have a specific cause in mind, but paying it forward to someone else in need sounds like a great idea.

The following example is the worst case as it shows valid examples of ti, di and dy in the same sentence.

After examining various solution graphs, it seems that correct tokens always come first, so the extension now uses this fact to remove the incorrect variations. I'd be interested to know if you stumble upon a case where it likely did not work though.

By the way, the solution parser is now available online: https://blmage.github.io/duo-solution-parser/, if you'd like to give it a try!

@TNG02
Copy link
Author

TNG02 commented Jul 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants