Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve search query in overlay state hook #15334

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

hawkeye217
Copy link
Collaborator

Proposed change

location.search was not being preserved in useOverlayState, so whenever the hook was used, it would clear any url parameters. This shows up when unmuting a video (which uses the hook) in Explore after filtering.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 0b7da67
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/674fd39d01a5da00088fb8a8
😎 Deploy Preview https://deploy-preview-15334--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit a729408 into dev Dec 4, 2024
13 checks passed
@NickM-27 NickM-27 deleted the fix-overlay-state branch December 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants