Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more unit tests for the review controller #15162

Merged
merged 22 commits into from
Dec 4, 2024

Conversation

iursevla
Copy link
Contributor

@iursevla iursevla commented Nov 24, 2024

Proposed change

Add more unit tests for the review controller endpoints

  • /review/summary
  • /reviews/viewed
  • /reviews/delete

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 3a9b69f
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67503cafce6d920008df7331
😎 Deploy Preview https://deploy-preview-15162--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iursevla iursevla changed the title Started unit tests for the review controller Added more unit tests for the review controller Nov 24, 2024
@NickM-27
Copy link
Collaborator

Can you sync with latest

@iursevla
Copy link
Contributor Author

#15162 (comment)

@NickM-27 Done

The missing endpoints for the review controller will come shortly afterward 🙏

@iursevla
Copy link
Contributor Author

iursevla commented Dec 4, 2024

@NickM-27 is there something missing?

Merging is blocked
This branch must not contain merge commits.

Is there something I need to do, or is everything okay?

I did merge upstream/dev into my branch

@NickM-27
Copy link
Collaborator

NickM-27 commented Dec 4, 2024

I thought we already merged this

@NickM-27 NickM-27 requested a review from hawkeye217 December 4, 2024 12:07
@hawkeye217 hawkeye217 merged commit a5a7cd3 into blakeblackshear:dev Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants