Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read UTF-16 XML files #44

Open
shpiyu opened this issue May 11, 2024 · 1 comment · May be fixed by #46
Open

Can't read UTF-16 XML files #44

shpiyu opened this issue May 11, 2024 · 1 comment · May be fixed by #46
Labels
good first issue Good for newcomers

Comments

@shpiyu
Copy link
Contributor

shpiyu commented May 11, 2024

Describe the bug
I tried reading an XML file that is encoded in UTF-16 but ingen could not read it. It creashed with UnicodeDecodeError while trying to read using my mahcine's default encoding (utf-8).

To Reproduce
Steps to reproduce the behavior:

  1. Create a XML file with UTF-16 encoding
  2. Try to read it via InGen by adding it as a data source
  3. See error:
Screenshot 2024-05-11 at 6 45 13 PM

Expected behavior
InGen should read UTF-16 files without crashing

Environment (please complete the following information):

  • Operating System: Mac

Additional context
We should add an option in the FileSource for users to declare the file encoding.

@shpiyu shpiyu added the good first issue Good for newcomers label May 28, 2024
@ChillarAnand ChillarAnand linked a pull request May 28, 2024 that will close this issue
9 tasks
@ChillarAnand
Copy link
Contributor

This is fixed in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants