Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks for hacks #18

Open
ches opened this issue Aug 30, 2017 · 5 comments
Open

Permalinks for hacks #18

ches opened this issue Aug 30, 2017 · 5 comments
Labels

Comments

@ches
Copy link
Member

ches commented Aug 30, 2017

Related to #7, permalinks for each hack night event:

As a hacker I want a direct link to view my hack, so that I can share my plan with others and invite them to join me.

Ideally I suppose we could use pushState so that when someone clicks to view their own hack they can simply copy the URL from the address bar. Could be something like:

https://bkkhack.github.io/hackmap/events/12/hacks/325548694

where 325548694 is the GitHub comment ID—I'm assuming that's what it is from URIs like this:

https://github.com/bkkhack/hackmap/issues/12#issuecomment-325548694
#12 (comment)

@ches
Copy link
Member Author

ches commented Aug 30, 2017

@djay
Copy link
Contributor

djay commented Sep 27, 2017

@ches given there should only be one comment per person, using the github id might make for a nicer url.

@ches
Copy link
Member Author

ches commented Jan 24, 2018

Thinking about it, not sure that relying on or enforcing one comment/hack per person would be desirable: there are times when I think of posting two ideas I could work on, and seeing which gets interest from others.

@waf
Copy link
Member

waf commented Jan 24, 2018

Yeah, it's interesting because we've coupled physical location with what you're hacking on. It makes sense to have more than one hack, but not to have more than one physical location.

I think the benefit of the coupling is that there's a very low learning curve for hackmap. In the past I've put multiple ideas in the hack description, which seems to work out OK.

@djay
Copy link
Contributor

djay commented Jan 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants