Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate opacity warning for gpu renderer and versions blacklist #411

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Aug 8, 2023

🚀 Pull Request

Description

This PR allows the ability to generate a text opacity warning which is added to the plotter scene for known troublesome GPU renderer and version combinations.

e.g., the following is generated with the clouds.py example on the Met Office VDI estate, where there are no GPUs and a llvmpipe rasterizer is being used with an older version of OpenGL.

image


@github-actions github-actions bot added the type: examples Auto-labelled for ex/*, example/* and examples/* branches label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #411 (ebad923) into main (7e08f96) will decrease coverage by 0.10%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   84.60%   84.51%   -0.10%     
==========================================
  Files          59       59              
  Lines        3242     3248       +6     
==========================================
+ Hits         2743     2745       +2     
- Misses        499      503       +4     
Files Changed Coverage Δ
src/geovista/common.py 89.33% <33.33%> (-1.27%) ⬇️

@bjlittle bjlittle merged commit 6a29147 into main Aug 8, 2023
17 checks passed
@bjlittle bjlittle deleted the warn-opacity branch August 8, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant