Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Zenoh to v1.0.0 🥳 #59

Open
takasehideki opened this issue Oct 21, 2024 · 3 comments · May be fixed by #79
Open

bump Zenoh to v1.0.0 🥳 #59

takasehideki opened this issue Oct 21, 2024 · 3 comments · May be fixed by #79
Assignees

Comments

@takasehideki
Copy link
Contributor

What an amazing happy news!! Zenoh v1.0.0 is finally coming!!
https://www.zettascale.tech/news/eclipse-zenoh-1-0-0-takes-flight/
https://github.com/eclipse-zenoh/zenoh/releases/tag/1.0.0

We should try to catch up this latest cool version!!

@takasehideki
Copy link
Contributor Author

takasehideki commented Oct 21, 2024

Here is the quick check, and unhappy report,,,;(

  1. Simply changed Cargo.toml to bump zenoh to v1.0.0 main...zenoh-v1.0.0
  2. mix deps.get && mix deps.compile worked fine
  3. mix compile caused too many error messages,,, 😢
$ mix compile
<sniped>
   Compiling zenohex_nif v0.3.0 (/home/takase/zenoh/zenohex/native/zenohex_nif)
error[E0433]: failed to resolve: could not find `prelude` in `zenoh`
 --> src/lib.rs:6:5
  |
6 |     prelude::sync::*, publication::Publisher, query::Reply, queryable::Query, queryable::Queryable,
  |     ^^^^^^^ could not find `prelude` in `zenoh`

<sniped>

error[E0282]: type annotations needed
  --> src/value.rs:14:61
   |
14 |                     let mut binary = OwnedBinary::new(value.len()).unwrap();
   |                                                             ^^^ cannot infer type for type parameter `B` declared on the enum `Cow`

Some errors have detailed explanations: E0277, E0282, E0432, E0433, E0599, E0609, E0616.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `zenohex_nif` (lib) due to 75 previous errors

== Compilation error in file lib/zenohex/nif.ex ==
** (RuntimeError) Rust NIF compile error (rustc exit code 101)
    (rustler 0.33.0) lib/rustler/compiler.ex:36: Rustler.Compiler.compile_crate/3
    lib/zenohex/nif.ex:8: (module)

Full version of log for mix compile:
mix_compile.log

@s-hosoai
Copy link
Collaborator

s-hosoai commented Oct 30, 2024

Thank you for attempting the migration to version 1.0.0.
I find several articles on the Zenoh Blog regarding the migration.

@takasehideki
Copy link
Contributor Author

This work has been moved to #79, So please give us your knowledge to there from now on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants