Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outgoing mail rewrite behavior in relation to allow_resend_from_re? #56

Open
schellj opened this issue Nov 15, 2022 · 0 comments
Open

Update outgoing mail rewrite behavior in relation to allow_resend_from_re? #56

schellj opened this issue Nov 15, 2022 · 0 comments

Comments

@schellj
Copy link
Contributor

schellj commented Nov 15, 2022 •
edited
Loading

There was discussion about mail rewrite behavior in relation to the allow_resend_from_re config (#54 (comment)) that resulted in commit 6e5b2c6, which caused some tests to fail unexpectedly (Mail/t/Outgoing2.bunit, PetShop/Test/t/mail.btest, PetShop/Test/t/rewrite-from-domain.btest). It was assumed previously that allow_resend_from_re was only relevant to tests, but it is actually used in production also. That commit was reverted in #55.

Is the current behavior correct and/or desirable?
@schellj schellj changed the title Update outgoing mail rewrite behavior in relation to allow_rewrite_from? Update outgoing mail rewrite behavior in relation to allow_resend_from_re? Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schellj