Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP attachment export #255

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP attachment export #255

wants to merge 7 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 25, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@bitwarden-bot
Copy link

bitwarden-bot commented Sep 25, 2023

Logo
Checkmarx One – Scan Summary & Details8866cb1b-2f03-41af-8923-b2b6992aa270

No New Or Fixed Issues Found

…port

# Conflicts:
#	crates/bitwarden/src/admin_console/policy.rs
#	crates/bitwarden/src/crypto/enc_string.rs
#	crates/bitwarden/src/lib.rs
#	crates/bitwarden/src/platform/domain.rs
#	crates/bitwarden/src/platform/mod.rs
#	crates/bitwarden/src/platform/sync.rs
#	crates/bitwarden/src/tool/exporters/client_exporter.rs
#	crates/bitwarden/src/tool/exporters/mod.rs
#	crates/bitwarden/src/vault/cipher/attachment.rs
#	crates/bitwarden/src/vault/cipher/cipher.rs
#	crates/bitwarden/src/vault/cipher/mod.rs
#	crates/bitwarden/src/vault/collection.rs
#	crates/bitwarden/src/vault/folder.rs
#	crates/bitwarden/src/vault/mod.rs
#	crates/bitwarden/src/vault/send.rs
#	crates/bw/src/auth/login.rs
#	crates/bw/src/main.rs
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 58.94%. Comparing base (8bed619) to head (e4c4b70).
Report is 354 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden/src/tool/exporters/mod.rs 0.00% 36 Missing ⚠️
crates/bitwarden/src/vault/cipher/attachment.rs 0.00% 34 Missing ⚠️
crates/bw/src/main.rs 0.00% 14 Missing ⚠️
...es/bitwarden/src/tool/exporters/client_exporter.rs 0.00% 4 Missing ⚠️
crates/bitwarden/src/vault/api/attachment.rs 0.00% 3 Missing ⚠️
crates/bitwarden-uniffi/src/tool/mod.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/vault/cipher/login.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/vault/cipher/card.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/cipher/cipher.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/cipher/field.rs 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   59.44%   58.94%   -0.50%     
==========================================
  Files         171      172       +1     
  Lines       10324    10411      +87     
==========================================
  Hits         6137     6137              
- Misses       4187     4274      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants