Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2FA (response 406) and possible login error 405 fixes #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2FA (response 406) and possible login error 405 fixes #220

wants to merge 1 commit into from

Conversation

usvi
Copy link
Collaborator

@usvi usvi commented Apr 1, 2023 •
edited
Loading

This pull request should help in 2 problems:

  1. The 2 factor authentication code should now be managed automatically and user instructed how to input it
  2. We should now get less, maybe even zero events were Facebook kicks us and notifies us: "User must verify their account on www.facebook.com (405)"

Technically

  • Introduced machine_id props and automatic requesting which I speculate helps in the 405 situation.
  • 2FA first_factor and the twofactor access code props, storing and use.
  • Automatic use of the 2FA when user has set the twofactor access code.
  • Twofactor access code automatic invalidation if dependent data has changed or on critical error.
  • Prompt about how to set the twofactor code.

@usvi
* machine_id props and automatic requesting
31b56ec 
  (Probably helps in other non-stable auth cases
   also as a side effect.)
* 2FA first_factor and the twofactor access code
  props, storing and use.
* Automatic use of the 2FA when user has set
  the twofactor ccess code.
* Twofactor access code automatic invalidation if
  dependant data has changed or on critical error.
* Prompt about how to set the twofactor code.
@usvi usvi changed the title 2FA and total Facebook kickout fixes 2FA (response 406) and possible login error 405 fixes Apr 1, 2023
@usvi
Copy link
Collaborator Author

usvi commented Apr 1, 2023

Solved the original error by the reporter here: #215

@usvi usvi mentioned this pull request Apr 2, 2024
Open
@dartraiden dartraiden mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@usvi