Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce OP_RETURN standardness #1726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enforce OP_RETURN standardness #1726

wants to merge 1 commit into from
+22 −0

Conversation

rustaceanrob
Copy link
Contributor

Closes #1718

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ValuedMammal
Copy link
Contributor

Should we use a default max size of 83 as shown here?

https://github.com/bitcoin/bitcoin/blob/110183746150428e6385880c79f8c5733b1361ba/src/policy/policy.h#L68-L72

@notmandatory notmandatory added audit Suggested as result of external code audit module-wallet labels Nov 18, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 18, 2024
@notmandatory notmandatory added the api A breaking API change label Nov 19, 2024
oleonardolima
oleonardolima approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f7d6dcf

@notmandatory notmandatory removed this from the 1.0.0-beta milestone Nov 20, 2024
@thunderbiscuit thunderbiscuit mentioned this pull request Nov 25, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@rustaceanrob rustaceanrob

Labels
api A breaking API change audit Suggested as result of external code audit module-wallet
Projects
BDK
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce standardness rules for TxBuilder::add_data
4 participants
@rustaceanrob @ValuedMammal @oleonardolima @notmandatory