From 493120634eb6eda4c81eb5c8373ff7eb950bacd1 Mon Sep 17 00:00:00 2001
From: Mads Bisgaard <bisgaard@itis.swiss>
Date: Tue, 10 Dec 2024 10:41:36 +0100
Subject: [PATCH] improve error messages in ci

---
 .github/workflows/ci-testing-pull-request.yml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci-testing-pull-request.yml b/.github/workflows/ci-testing-pull-request.yml
index 3d877cb091a..7a111e24f66 100644
--- a/.github/workflows/ci-testing-pull-request.yml
+++ b/.github/workflows/ci-testing-pull-request.yml
@@ -35,11 +35,13 @@ jobs:
         run: |
           uv venv .venv && source .venv/bin/activate
           make openapi-specs
-          ./ci/github/helpers/openapi-specs-diff.bash diff \
+          if !./ci/github/helpers/openapi-specs-diff.bash diff \
             https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/refs/heads/${{ github.event.pull_request.head.ref }} \
-            .
+            .; then \
+            echo "::error OAS are not up to date. Run 'make openapi-specs' to update them"; \
+          fi
 
-  api-server-backwards-compatibility:
+  api-server-oas-breaking:
     needs: api-specs
     timeout-minutes: 10
     name: "api-server backwards compatibility"
@@ -62,7 +64,7 @@ jobs:
             https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json \
             /specs/services/api-server/openapi.json
 
-  oas-backwards-compatibility:
+  all-oas-breaking:
     needs: api-specs
     continue-on-error: true
     timeout-minutes: 10