Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors for generated inits #392

Open
carrascomj opened this issue Jun 23, 2022 · 1 comment
Open

Better errors for generated inits #392

carrascomj opened this issue Jun 23, 2022 · 1 comment

Comments

@carrascomj
Copy link
Member

Description

In the user_generated_inits file, if there is a row specifying conc_unbalanced parameters for balanced metabolites, maud will spit a wall of Stan errors:

...
Exception: ode_bdf_tol: ode parameters and data[14] is nan, but must be finite! (in '/home/georg/git/maud.git/master/src/maud/stan/model.stan', line 156, column 4 to line 203, column 39)
Exception: ode_bdf_tol: ode parameters and data[14] is nan, but must be finite! (in '/home/georg/git/maud.git/master/src/maud/stan/model.stan', line 156, column 4 to line 203, column 39)
Exception: ode_bdf_tol: ode parameters and data[14] is nan, but must be finite! (in '/home/georg/git/maud.git/master/src/maud/stan/model.stan', line 156, column 4 to line 203, column 39)
...

This can happen if/when the user changes a metabolite from unbalanced to balanced and forgets about the inits file.

Desired behavior

Some very light validation for the generated inits would be great to enhance UX.

@teddygroves
Copy link
Member

yes this is definitely necessary, I get errors like that to do with inits all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants