Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with cases where experiments are encoded as Python scripts #26

Open
bilalshaikh42 opened this issue Jan 5, 2022 · 1 comment
Open
Labels

Comments

@bilalshaikh42
Copy link
Member

@jonrkarr is this something that we would be able to support? For some experiments rather than provide a sedml file, the authors provide python files that are meant to be run as follows:

[PathToOpenCOR]/pythonshell fig3-new.py

This would require a change to simulator specs. We would need to encode the types of valid simulation experiment files. We would lose the structured log output unless we can treat each python file as a task.

source:

https://models.physiomeproject.org/e/7d5

@jonrkarr
Copy link
Member

jonrkarr commented Jan 5, 2022

I suggest we

  • Publish these projects
  • Include the Python scripts in the COMBINE archives we create as supplementary files
  • Not try to execute these Python scripts
  • Encourage Physiome users to make more use of SED-ML

Rationale:

  • It looks like this example could be done with CellML and SED-ML. The need for this appears to stem from OpenCOR's limited support for SED-ML, which we have addressed (external to OpenCOR).
  • The Python files in this example are partially redundant with the SED-ML because they read the SED-ML.
  • The Python scripts contain both simulations and models.
  • I'm not sure the Python scripts save anything

@jonrkarr jonrkarr changed the title Deal with cases where experiments are encoded as python scripts Deal with cases where experiments are encoded as Python scripts Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants