Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register FEMA and JECFA numbers #1247

Closed
bgyori opened this issue Nov 3, 2024 · 5 comments
Closed

Register FEMA and JECFA numbers #1247

bgyori opened this issue Nov 3, 2024 · 5 comments
Assignees

Comments

@bgyori
Copy link
Contributor

bgyori commented Nov 3, 2024

Similar to #1246, encountered FEMA and JECFA numbers as cross-references for compounds.

FEMA: https://www.femaflavor.org/, e.g., 4667, unfortunately, the URLs don't use the ID but rather the name, e.g., https://www.femaflavor.org/flavor-library/24-ethyl-426-dimethyldihydro-135-dithiazine-mixture-isomers.

JECFA: https://apps.who.int/food-additives-contaminants-jecfa-database/, e.g, 2116, again, unfortunately, the URLs don't use the JECFA ID (but some other number that is completely different): https://apps.who.int/food-additives-contaminants-jecfa-database/Home/Chemical/6163. This actually appears in WikiData as P4852 (see external/wikidata/processed.json) but I believe the WikiData record confounds the numbers used in the URL with what is actually called a JECFA ID.

@nagutm
Copy link
Collaborator

nagutm commented Nov 3, 2024

I can look into this

@nagutm
Copy link
Collaborator

nagutm commented Nov 4, 2024

JECFA:

  • Although the URL uses a different number than the JECFA ID, not all entries in this resource contain a specific JECFA ID example 1, example 2 that is distinct from the one in the URL.
  • Given this, I think that we can curate this in the bioregistry with the number in the URL as the main identifier.

FEMA:

  • Although this resource provides references to the FEMA, JECFA and CAS numbers, none of these identifiers are resolvable through the URL.
  • Given that this is a notable resource, we could curate it with the name of the chemical as the main identifier and possibly add the FEMA number in the example_extras field.

@bgyori
Copy link
Contributor Author

bgyori commented Nov 4, 2024

Thanks for looking into this @nagutm. I would approach this not from the perspective of the URI patterns (which seem to use arbitrary IDs that are not defined anywhere) but from the perspective of the actual FEMA and JECFA IDs (which are defined and appear in cross-references and therefore necessitate a prefix to be representable). So let's curate new prefixes for the FEMA/JECFA IDs and for the time being assume that there is no URI pattern to resolve these - unless of course we find a provider somewhere.

@bgyori
Copy link
Contributor Author

bgyori commented Nov 4, 2024

After a bit more digging I actually found that WikiData has two different properties for JECFA, including this: https://www.wikidata.org/wiki/Property:P9557 ("JECFA number") which is the one we should be mapping to instead of P4852.

bgyori added a commit that referenced this issue Nov 5, 2024
This pull request addresses part of
#1247 by introducing
a new prefix `fema`.

Since the URL for individual entries does not use the FEMA Number, but
rather the name of the chemical, it is curated without a `uri_format`
field.

---------

Co-authored-by: Mufaddal Naguthanawala <[email protected]>
Co-authored-by: Ben Gyori <[email protected]>
bgyori added a commit that referenced this issue Nov 5, 2024
This pull request addresses part of
#1247 by introducing
a new prefix `jecfa`.

Since the URL for individual entries does not use the JECFA Number, but
rather an unrelated number, it is curated without a `uri_format` field.

---------

Co-authored-by: Mufaddal Naguthanawala <[email protected]>
Co-authored-by: Ben Gyori <[email protected]>
@bgyori
Copy link
Contributor Author

bgyori commented Nov 7, 2024

Done in #1254 and #1255.

@bgyori bgyori closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants