-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register FEMA and JECFA numbers #1247
Comments
I can look into this |
JECFA:
FEMA:
|
Thanks for looking into this @nagutm. I would approach this not from the perspective of the URI patterns (which seem to use arbitrary IDs that are not defined anywhere) but from the perspective of the actual FEMA and JECFA IDs (which are defined and appear in cross-references and therefore necessitate a prefix to be representable). So let's curate new prefixes for the FEMA/JECFA IDs and for the time being assume that there is no URI pattern to resolve these - unless of course we find a provider somewhere. |
After a bit more digging I actually found that WikiData has two different properties for JECFA, including this: https://www.wikidata.org/wiki/Property:P9557 ("JECFA number") which is the one we should be mapping to instead of P4852. |
This pull request addresses part of #1247 by introducing a new prefix `fema`. Since the URL for individual entries does not use the FEMA Number, but rather the name of the chemical, it is curated without a `uri_format` field. --------- Co-authored-by: Mufaddal Naguthanawala <[email protected]> Co-authored-by: Ben Gyori <[email protected]>
This pull request addresses part of #1247 by introducing a new prefix `jecfa`. Since the URL for individual entries does not use the JECFA Number, but rather an unrelated number, it is curated without a `uri_format` field. --------- Co-authored-by: Mufaddal Naguthanawala <[email protected]> Co-authored-by: Ben Gyori <[email protected]>
Similar to #1246, encountered FEMA and JECFA numbers as cross-references for compounds.
FEMA: https://www.femaflavor.org/, e.g., 4667, unfortunately, the URLs don't use the ID but rather the name, e.g., https://www.femaflavor.org/flavor-library/24-ethyl-426-dimethyldihydro-135-dithiazine-mixture-isomers.
JECFA: https://apps.who.int/food-additives-contaminants-jecfa-database/, e.g, 2116, again, unfortunately, the URLs don't use the JECFA ID (but some other number that is completely different): https://apps.who.int/food-additives-contaminants-jecfa-database/Home/Chemical/6163. This actually appears in WikiData as P4852 (see external/wikidata/processed.json) but I believe the WikiData record confounds the numbers used in the URL with what is actually called a JECFA ID.
The text was updated successfully, but these errors were encountered: