Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pandas_compat: fix table_from_frames for "normal" dataframe #5652

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Oct 18, 2021

Issue

table_from_frames errored when it recieved a dataframe which is not OrangeDataFrame. Look at new test for an example.
fixes #5622

Description of changes

This PR solves two errors:

  • do not expect df.orange_attributes for data frame that is not OrangeDataFrame
  • make vars_from_df use take into account role parameter for data frame which is not OrangeDataFrame
  • make sure indexes of all three data frames are equal and if index is not range index it should be placed in metas
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Contributor Author

This PR cannot be merged before #5620

@PrimozGodec PrimozGodec marked this pull request as draft October 19, 2021 12:06
@PrimozGodec PrimozGodec marked this pull request as ready for review October 25, 2021 13:34
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #5652 (fd9d708) into master (3634e37) will decrease coverage by 0.03%.
The diff coverage is 97.77%.

❗ Current head fd9d708 differs from pull request most recent head 9afaa96. Consider uploading reports for the commit 9afaa96 to get more accurate results

@@            Coverage Diff             @@
##           master    #5652      +/-   ##
==========================================
- Coverage   86.07%   86.04%   -0.04%     
==========================================
  Files         315      315              
  Lines       66048    65930     -118     
==========================================
- Hits        56854    56731     -123     
- Misses       9194     9199       +5     

@VesnaT VesnaT merged commit 542435d into biolab:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants