[FIX] pandas_compat: fix conversion of datetime series #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
2 times, most recently
from
25b7a48
to
84ad9e8
Compare
3 tasks
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
from
84ad9e8
to
b2c7c75
Compare
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
from
54d7414
to
2aa365a
Compare
Codecov Report
@@ Coverage Diff @@
## master #5547 +/- ##
==========================================
- Coverage 86.38% 85.90% -0.48%
==========================================
Files 304 313 +9
Lines 61801 65353 +3552
==========================================
+ Hits 53386 56143 +2757
- Misses 8415 9210 +795 |
ajdapretnar
reviewed
Aug 13, 2021
| if (dt_nonnat.dt.floor("d") == dt_nonnat).all(): | ||
| # all times are 00:00:00.0 - pure date | ||
| return 1, 0 | ||
| elif (dt_nonnat.dt.date == pd.Timestamp("now").date()).all(): |
There was a problem hiding this comment.
Does pandas automatically assume today's date if only time is present?
There was a problem hiding this comment.
yep. When pd.datetime() is called on column of times it will be transformed to datetime64 and all dates will be today's dates
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
2 times, most recently
from
6bb5083
to
b177f81
Compare
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
from
b177f81
to
4ffed33
Compare
PrimozGodec
force-pushed
the
pandas_compat-fix-time-var-coversion
branch
from
4ffed33
to
672de2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
datetime.strftimeand specified formats (e.g. pandas output time on nanosecond precision while DateTime only support reading of milliseconds precision max, and some other cases). It could be solvable via some string manipulation which is heavily error prune.Description of changes
timezoneattribute. Storing utc_offset in TimeVariable is also not a good practice since two dates in the same timezone can have two different offsets depending on summer, wintertime or time zones changes in history. Remembering the timezone is more suitable.Includes