Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Rank: Switch to manual selection on deselect #5271

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 17, 2021

Issue

Fixes #5126.

Description of changes

view.pressed(QModeIndex) is not emitted when index is invalid. selectionModel().selectionChanged(...) would not distinguish between changes because of clicking and programmatic changes. Hence I overrode mousePressEvent, which, in super-super-class calls the select.

I want add tests because I don't know how to.

Includes
  • Code changes

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #5271 (4cef10d) into master (50345c2) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master    #5271   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files         300      300           
  Lines       60977    60981    +4     
=======================================
+ Hits        51950    51955    +5     
+ Misses       9027     9026    -1     

@markotoplak markotoplak merged commit 96d174f into biolab:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rank widget show inconsistent settings
2 participants