Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] New widget: Aggregate Columns #5256

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 11, 2021

Issue

Closes #5066.

Builds on #5251.

Screenshot 2021-02-11 at 18 10 47

Description of changes

Add a new widget.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd changed the title [ENH] New widget: Aggregate Columns [RFC] [ENH] New widget: Aggregate Columns Feb 11, 2021
@janezd janezd marked this pull request as draft February 11, 2021 17:13
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #5256 (8221026) into master (69e580d) will increase coverage by 0.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5256      +/-   ##
==========================================
+ Coverage   85.35%   86.26%   +0.91%     
==========================================
  Files         301      301              
  Lines       62035    61117     -918     
==========================================
- Hits        52950    52723     -227     
+ Misses       9085     8394     -691     

@janezd
Copy link
Contributor Author

janezd commented Feb 12, 2021

If all variables are TimeVariable, output TimeVariable.

@janezd janezd force-pushed the aggregate-columns branch 4 times, most recently from b72d196 to 7e2db04 Compare February 16, 2021 20:05
@janezd janezd changed the title [RFC] [ENH] New widget: Aggregate Columns [ENH] New widget: Aggregate Columns Feb 18, 2021
@janezd
Copy link
Contributor Author

janezd commented Feb 25, 2021

@ajdapretnar, could you check this and write the documentation if you think it's OK?

I'm asking you this just because you've more experience in this. You can tell me to do it myself and I will.

@ajdapretnar
Copy link
Contributor

I will, but on Monday.

@janezd janezd assigned ajdapretnar and unassigned BlazZupan Mar 1, 2021
@ajdapretnar
Copy link
Contributor

I have everything ready, but I can't build widget.json catalogue, because the widget is missing an icon. :/

@ajdapretnar
Copy link
Contributor

Ok, I've added the documentation with a manually created widget.json. Do not try this at home. Might cause issues on the website due to the missing icon. :(

@janezd janezd assigned BlazZupan and unassigned ajdapretnar Mar 5, 2021
@janezd
Copy link
Contributor Author

janezd commented Mar 5, 2021

@BlazZupan will ask @larazupan to draw an icon.

@janezd janezd marked this pull request as ready for review March 11, 2021 14:11
@janezd janezd mentioned this pull request Mar 11, 2021
3 tasks
@BlazZupan
Copy link
Contributor

Works as intended :)

@BlazZupan BlazZupan merged commit 100a192 into biolab:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge columns into one
4 participants