Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] colorpalettes: fix BinnedContinuousPalette color assignments #4609

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

robertcv
Copy link
Collaborator

@robertcv robertcv commented Apr 1, 2020

Issue

There is an inconsistency between decimal_binnings and BinnedContinuousPalette on whether the equal sign is on the upper or lower border of bins.
The result is that we get the wrong colors for data points that lie on the border between bins.

Includes
  • Code changes
  • Tests
  • Documentation

@robertcv robertcv requested a review from janezd April 1, 2020 14:29
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #4609 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #4609      +/-   ##
=========================================
- Coverage   83.62%   83.6%   -0.02%     
=========================================
  Files         281     276       -5     
  Lines       56194   55389     -805     
=========================================
- Hits        46991   46309     -682     
+ Misses       9203    9080     -123

@janezd janezd merged commit c999ab9 into biolab:master Apr 3, 2020
@robertcv robertcv deleted the fix/binned_palette branch April 9, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants